Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new LastInfoSec analyzers for hash and domain #754

Merged
merged 7 commits into from
Jun 17, 2020
Merged

new LastInfoSec analyzers for hash and domain #754

merged 7 commits into from
Jun 17, 2020

Conversation

remydewa
Copy link
Contributor

new LastInfoSec analyzers for hash and domain
Related issue: #753

@remydewa
Copy link
Contributor Author

LastInfoSec analyzer added. Ready to merge

@dadokkio dadokkio added status:needs-template Analyzer still needs a template for TheHive category:new-analyzer New analyzer submitted status:pr-submitted and removed status:needs-template Analyzer still needs a template for TheHive category:new-analyzer New analyzer submitted status:pr-submitted labels Apr 28, 2020
@remydewa
Copy link
Contributor Author

Do I have something to do? Who will validate the PR? What is the process of validation?

Thanks :)

@dadokkio
Copy link
Contributor

dadokkio commented Apr 30, 2020 •
edited
Loading

Hi, thanks for the pull.
One of the missing step to be integrated are the templates for the hive. Can you create and add them to the pull?
Then someone of the reviewer will test your code, review it, and then it'll merged (probably in 2.8.0)

@remydewa
Copy link
Contributor Author

remydewa commented May 3, 2020

@dadokkio Hi, thanks for reply.
I have added the templates. Don't hesitate to come back to me if needed.

Rémy

@dadokkio
Copy link
Contributor

dadokkio commented May 3, 2020

Perfect, do you think I could ask for a temporary key just to test the code?

@remydewa
Copy link
Contributor Author

remydewa commented May 8, 2020 •
edited
Loading

Yes, for sure. I will send you an email with the details of the contract this weekend.

Rémy

@dadokkio
Copy link
Contributor

Hi @remydewa , I didn't receive any email yet. It this correct?

@dadokkio dadokkio added this to the 2.8.0 milestone Jun 5, 2020
@dadokkio dadokkio changed the base branch from develop to release/2.8.0 June 7, 2020 12:42
@dadokkio dadokkio changed the base branch from release/2.8.0 to develop June 9, 2020 16:57
@dadokkio dadokkio changed the base branch from develop to release/2.8.0 June 17, 2020 08:07
@dadokkio dadokkio merged commit 337a4dd into TheHive-Project:release/2.8.0 Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@remydewa @dadokkio