Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

findSimilarJob function broken #144

Closed
saadkadhi opened this issue Oct 11, 2018 · 1 comment
Closed

findSimilarJob function broken #144

saadkadhi opened this issue Oct 11, 2018 · 1 comment
Assignees
@To-om
Labels
bug
Milestone
2.1.2

Comments

@saadkadhi
Copy link
Contributor

Request Type

Bug

Work Environment

Question Answer
OS version (server) RedHat
OS version (client) Windows 7 Enterprise SP1
Cortex version / git hash 2.1.0, bc11d5c
Package Type From source

Problem Description

When running a job in Cortex with the exact same details, the function findSimilarJob is called. It should return results from any previous jobs, but in the latest version it does not.

We believe the call to elastic to find the similar jobs is broken.

Possible Solutions

analyzerId should be workerId in the findSimilarJob function.

Complementary information

The attribute analyzerId has previously been changed to workerId.
@saadkadhi saadkadhi added the bug label Oct 11, 2018
@saadkadhi
Copy link
Contributor Author

This is confirmed by @To-om on 2.1.1 as well.

@saadkadhi saadkadhi added this to the 2.1.2 milestone Oct 11, 2018
To-om added a commit that referenced this issue Oct 12, 2018
@To-om
#144 #145 Fix missing attribute renamings
a3d49a5
@To-om To-om closed this as completed Oct 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@To-om To-om

Labels
bug
Projects
None yet
Milestone
2.1.2
Development

No branches or pull requests
2 participants
@saadkadhi @To-om