Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker.sbt + entrypoint to fix 3.1.0-0.1RC1 #285

Closed
wants to merge 2 commits into from

Conversation

8ear
Copy link
Contributor

@8ear 8ear commented Aug 30, 2020

Fix docker.sbt with the correct user (cortex != thehive) and fix the gid for the group to have the same as the standard docker group.

8ear added 2 commits August 30, 2020 23:47
Fix docker.sbt with the correct user (cortex != thehive) and fix the gid for the group to have the same as the standard docker group.
Fix entrypoint to preven su password authentication
@To-om
Copy link
Contributor

To-om commented Aug 31, 2020

Thank you for your PR. I've manually merged into develop branch (I've changed uid from 999 to 1001).

@To-om To-om closed this Aug 31, 2020
@garanews
Copy link
Contributor

@8ear confirmed working, thanks :)

@8ear
Copy link
Contributor Author

8ear commented Aug 31, 2020

Hi @To-om,
It is very important that the GID must be 999. Because it is the stanard GID for docker. So the docker.sock file has directly the correct permissions.

@To-om
Copy link
Contributor

To-om commented Aug 31, 2020

You are right the GID is important otherwise Cortex service won't be able to connect to Docker daemon.
I don't know which distribution you use but in Debian package, docker group is created without setting the GID (groupadd --system docker => the higher available GID less that 1000 is used). In my Ubuntu, the GID of docker is 998. I don't know what is the best solution to address this problem.

@8ear
Copy link
Contributor Author

8ear commented Aug 31, 2020

Let me think a little about that and experiment a little bit ok?
In which branch you will have ma PR if I am ready?

@To-om
Copy link
Contributor

To-om commented Aug 31, 2020

I merged PR in develop branch

@8ear 8ear deleted the patch-2 branch September 1, 2020 20:53
@To-om To-om mentioned this pull request Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants