#1412: Fix the deleteing of filter predicates from the filter preview…

… widget
TheHive-Project · Jun 27, 2020 · 1848f5c · 1848f5c
1 parent a1e75ae
commit 1848f5c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/frontend/app/scripts/filters/filter-value.js b/frontend/app/scripts/filters/filter-value.js
@@ -26,7 +26,7 @@
                 return [value.operator, value.value].join(' ');
             }
 
-            return value || 'Any';
+            return value !== undefined && value !== null ? value : 'Any';
         };
     });
 

diff --git a/frontend/app/views/components/search/filters-preview.component.html b/frontend/app/views/components/search/filters-preview.component.html
@@ -3,11 +3,11 @@
         <li>{{$ctrl.filters.length}}
             filter(s) applied:
         </li>
-        <li class="filter-item" ng-repeat="filter in $ctrl.filters">
+        <li class="filter-item" ng-repeat="filter in $ctrl.filters track by $index">
             <span>
-                <strong>{{filter.field}}:</strong>
+                <strong>{{filter.field || '???'}}:</strong>
                 {{filter.value | filterValue}}</span>
-            <a href ng-click="$ctrl.clearItem(field)">
+            <a href ng-click="$ctrl.clearItem($index)">
                 <span class="filter-close fa fa-times text-danger"></span>
             </a>
         </li>
-Original file line number
+Diff line change
@@ Expand Up / @@ -26,7 +26,7 @@ @@
                     return [value.operator, value.value].join(' ');
                 }
-                return value || 'Any';
+                return value !== undefined && value !== null ? value : 'Any';
             };
         });
@@ Expand Down @@