#1432 Allow user without manageShare to see the tasks and observables…

… shares without allowing them to add new shares
TheHive-Project · Jul 16, 2020 · 73ee961 · 73ee961
1 parent 0c43f15
commit 73ee961
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 8 deletions.
diff --git a/frontend/app/views/partials/case/case.sharing.html b/frontend/app/views/partials/case/case.sharing.html
@@ -1,4 +1,4 @@
-<div class="row mb-s" if-permission="manageCase" allowed="{{userPermissions}}">
+<div class="row mb-s" if-permission="manageShare" allowed="{{userPermissions}}">
     <div class="col-md-12">
         <div class="btn-toolbar" role="toolbar">
             <div class="btn-group">

diff --git a/frontend/app/views/partials/case/case.tasks.item.html b/frontend/app/views/partials/case/case.tasks.item.html
@@ -3,7 +3,8 @@ <h4 class="mb-xs text-primary">
         Basic Information
 
         <div class="task-actions pull-right" if-permission="manageTask" allowed="{{userPermissions}}">
-            <span if-permission="manageShare" allowed="{{userPermissions}}">
+            <!-- <span if-permission="manageShare" allowed="{{userPermissions}}"> -->
+            <span>
                 <a href ng-click="scrollTo('#task-sharings')">
                     <span class="mr-xxs action-button">
                         <i class="fa fa-users"></i> Sharing
@@ -220,9 +221,10 @@ <h4 class="vpad10 text-primary">Task logs</h4>
         <psearch control="logs"></psearch>
     </div>
 
-    <div class="col-md-12" id="task-sharings" if-permission="manageShare" allowed="{{userPermissions}}">
+    <!-- <div class="col-md-12" id="task-sharings" if-permission="manageShare" allowed="{{userPermissions}}"> -->
+    <div class="col-md-12" id="task-sharings">
          <h4 class="vpad10 text-primary">Task sharing</h4>
-         <div class="btn-toolbar" role="toolbar">
+         <div class="btn-toolbar" role="toolbar" if-permission="manageShare" allowed="{{userPermissions}}">
              <div class="btn-group">
                  <button class="btn btn-sm btn-primary" ng-click="addTaskShare()">
                      <i class="fa fa-plus"></i>

diff --git a/frontend/app/views/partials/observables/details/sharing.html b/frontend/app/views/partials/observables/details/sharing.html
@@ -1,7 +1,7 @@
 <div class="row">
-    <div class="col-md-12" id="observable-sharings" if-permission="manageShare" allowed="{{userPermissions}}">
+    <div class="col-md-12" id="observable-sharings">
          <h4 class="vpad10 text-primary">Sharing</h4>
-         <div class="btn-toolbar" role="toolbar">
+         <div class="btn-toolbar" role="toolbar" if-permission="manageShare" allowed="{{userPermissions}}">
              <div class="btn-group">
                  <button class="btn btn-sm btn-primary" ng-click="addTaskShare()">
                      <i class="fa fa-plus"></i>
@@ -14,7 +14,7 @@ <h4 class="vpad10 text-primary">Sharing</h4>
                  shares="shares"
                  read-only="true"
                  on-delete="removeShare(share)"
-                 permissions="userPermissions"                 
+                 permissions="userPermissions"
                  ></sharing-list>
          </div>
     </div>

diff --git a/frontend/app/views/partials/observables/details/summary.html b/frontend/app/views/partials/observables/details/summary.html
@@ -4,7 +4,8 @@
         <h4 class="vpad10 text-primary">
             Metadata
             <div class="task-actions pull-right">
-                <span if-permission="manageShare" allowed="{{userPermissions}}">
+                <!-- <span if-permission="manageShare" allowed="{{userPermissions}}"> -->
+                <span>
                     <a href ng-click="scrollTo('#observable-sharings')">
                         <span class="mr-xxs action-button">
                             <i class="fa fa-users"></i> Sharing