#68 Add an editable field to the observable details page, to allow se…

…tting an observable as IOC
TheHive-Project · Dec 30, 2016 · a92d3c8 · a92d3c8
1 parent 1d1a9e1
commit a92d3c8
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 11 deletions.
diff --git a/ui/app/scripts/controllers/case/CaseObservablesItemCtrl.js b/ui/app/scripts/controllers/case/CaseObservablesItemCtrl.js
@@ -19,7 +19,7 @@
 
             $scope.artifact = {};
             $scope.artifact.tlp = $scope.artifact.tlp || -1;
-            $scope.analysisEnabled = VersionSrv.hasCortex();        
+            $scope.analysisEnabled = VersionSrv.hasCortex();
 
             $scope.editorOptions = {
                 lineNumbers: true,
@@ -105,7 +105,7 @@
                     startDate: job.startDate,
                     endDate: job.endDate
                 };
-            }
+            };
 
             $scope.similarArtifacts = CaseArtifactSrv.api().similar({
                 'artifactId': observableId
@@ -114,7 +114,7 @@
 
             $scope.openArtifact = function (a) {
                 $state.go('app.case.observables-item', {
-                    caseId: a["case"].id,
+                    caseId: a['case'].id,
                     itemId: a.id
                 });
             };
@@ -135,18 +135,20 @@
 
                 return CaseArtifactSrv.api().update({
                     artifactId: $scope.artifact.id
-                }, field, function () {}, function (response) {
+                }, field, function (response) {                    
+                    $scope.artifact = response.toJSON();
+                }, function (response) {
                     AlertSrv.error('artifactDetails', response.data, response.status);
                 });
             };
 
             $scope._runAnalyzer = function (serverId, analyzerId, artifactId) {
                 return CortexSrv.createJob({
                     cortexId: serverId,
-                    artifactId: $scope.artifact.id,
+                    artifactId: artifactId,
                     analyzerId: analyzerId
                 });
-            }
+            };
 
             $scope.runAnalyzer = function (analyzerId) {
                 var artifactName = $scope.artifact.data || $scope.artifact.attachment.name;
@@ -168,7 +170,7 @@
                 var artifactId = $scope.artifact.id;
                 var artifactName = $scope.artifact.data || $scope.artifact.attachment.name;
                 var analyzerIds = _.pluck(_.filter($scope.analyzers, function (a) {
-                    return a.active = true;
+                    return a.active === true;
                 }), 'id');
 
                 CortexSrv.getServers(analyzerIds)
@@ -179,9 +181,7 @@
                     })
                     .then(function () {
                         AlertSrv.log('Analyzers has been successfully started for observable: ' + artifactName, 'success');
-                    }, function () {
-
-                    })
+                    });
             };
 
         }

diff --git a/ui/app/views/partials/case/case.observables.item.html b/ui/app/views/partials/case/case.observables.item.html
@@ -4,7 +4,7 @@
     <div class="col-md-11 col-md-offset-1" ng-show="artifact.data != undefined">
         <div class="col-md-12">
             <h4>
-                <span class="text-muted glyphicon " ng-class="{true:'text-primary glyphicon-star'}[artifact.ioc]" tooltip-placement="bottom" tooltip-popup-delay="500" tooltip="is an IOC"></span>
+                <span class="text-muted fa " ng-class="{true:'text-primary fa-star'}[artifact.ioc]" tooltip-placement="bottom" tooltip-popup-delay="500" tooltip="is an IOC"></span>
                 [<span ng-bind="artifact.dataType" style="text-transform: uppercase;"></span>]: <em><span class="wrap">{{artifact.data | fang}}</span></em>
             </h4>
         </div>

diff --git a/ui/app/views/partials/observables/details/artifact-details-information.html b/ui/app/views/partials/observables/details/artifact-details-information.html
@@ -28,6 +28,20 @@ <h3 class="vpad10 text-primary">Observable Information</h3>
 			<dd>{{artifact.startDate | showDate}}</dd>
 		</dl>
 
+        <dl class="dl-horizontal clear">
+			<dt class="pull-left">Is IOC</dt>
+			<dd>
+				<span ng-init="iocActive = false" ng-mouseenter="iocActive = true" ng-mouseleave="iocActive = false" ng-click="updateField('ioc', !artifact.ioc)">
+                    <i class="text-primary fa" ng-class="{'true': 'fa-star', 'false': 'fa-star-o'}[artifact.ioc]"></i>
+                    <small ng-show="iocActive">
+                        <a href class="clickable" tooltip="edit">
+                            <i class="glyphicon glyphicon-pencil"></i>
+                        </a>
+                    </small>
+				</span>
+			</dd>
+		</dl>
+
 		<dl class="dl-horizontal clear">
 			<dt class="pull-left">Labels</dt>
 			<dd>