#1946 Improve performance of case->alert query

TheHive-Project · Apr 10, 2021 · ac538fe · ac538fe
1 parent d92e402
commit ac538fe
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/thehive/app/org/thp/thehive/controllers/v1/CaseCtrl.scala b/thehive/app/org/thp/thehive/controllers/v1/CaseCtrl.scala
@@ -34,6 +34,7 @@ class CaseCtrl @Inject() (
     userSrv: UserSrv,
     taskSrv: TaskSrv,
     organisationSrv: OrganisationSrv,
+    alertSrv: AlertSrv,
     db: Database,
     appConfig: ApplicationConfig
 ) extends QueryableCtrl
@@ -80,7 +81,12 @@ class CaseCtrl @Inject() (
     ),
     Query[Traversal.V[Case], Traversal.V[User]]("assignableUsers", (caseSteps, authContext) => caseSteps.assignableUsers(authContext)),
     Query[Traversal.V[Case], Traversal.V[Organisation]]("organisations", (caseSteps, authContext) => caseSteps.organisations.visible(authContext)),
-    Query[Traversal.V[Case], Traversal.V[Alert]]("alerts", (caseSteps, authContext) => caseSteps.alert.visible(organisationSrv)(authContext)),
+    Query[Traversal.V[Case], Traversal.V[Alert]](
+      "alerts",
+      (caseSteps, authContext) =>
+//      caseSteps.alert.visible(organisationSrv)(authContext)
+        alertSrv.startTraversal(caseSteps.graph).has(_.caseId, P.within(caseSteps._id.toSeq: _*)).visible(organisationSrv)(authContext)
+    ),
     Query[Traversal.V[Case], Traversal.V[Share]]("shares", (caseSteps, authContext) => caseSteps.shares.visible(authContext)),
     Query[Traversal.V[Case], Traversal.V[Procedure]]("procedures", (caseSteps, _) => caseSteps.procedure)
   )