#1564 Sort responders by name

TheHive-Project · Oct 20, 2020 · f8959cf · f8959cf
1 parent 772d387
commit f8959cf
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 8 deletions.
diff --git a/ui/app/scripts/controllers/case/CaseObservablesCtrl.js b/ui/app/scripts/controllers/case/CaseObservablesCtrl.js
@@ -654,7 +654,7 @@
             $scope.showReport = function(observable, analyzerId) {
                 CortexSrv.getJobs($scope.caseId, observable.id, analyzerId, 1)
                     .then(function(response) {
-                        return CortexSrv.getJob(response.data[0].id)
+                        return CortexSrv.getJob(response.data[0].id);
                     })
                     .then(function(response){
                         var job = response.data;
@@ -684,8 +684,8 @@
                     })
                     .catch(function(err) {
                         NotificationSrv.error('Unable to fetch the analysis report');
-                    })
-            }
+                    });
+            };
 
             $scope.getObsResponders = function(observableId, force) {
                 if(!force && $scope.obsResponders !== null) {
@@ -698,8 +698,8 @@
                       $scope.obsResponders = responders;
                   })
                   .catch(function(err) {
-                      NotificationSrv.error('observablesList', response.data, response.status);
-                  })
+                      NotificationSrv.error('observablesList', err.data, err.status);
+                  });
             };
 
             $scope.runResponder = function(responderId, responderName, artifact) {
@@ -721,7 +721,7 @@
         this.observable = observable;
         this.close = function() {
             $uibModalInstance.dismiss();
-        }
+        };
     });
 
 })();
diff --git a/ui/app/scripts/services/CortexSrv.js b/ui/app/scripts/services/CortexSrv.js
@@ -97,10 +97,9 @@
         };
 
         this.getResponders = function(type, id) {
-            //return $http.get(baseUrl + '/responder')
             return $http.get(baseUrl + '/responder/' + type + '/' + id)
               .then(function(response) {
-                  return $q.resolve(response.data);
+                  return $q.resolve(_.sortBy(response.data, 'name'));
               })
               .catch(function(err) {
                   return $q.reject(err);