#1844 Allow cancel action request from tasks

TheHive-Project · Mar 17, 2021 · fa79c88 · fa79c88
1 parent 58cfda3
commit fa79c88
Show file tree

Hide file tree

Showing 4 changed files with 38 additions and 4 deletions.
diff --git a/frontend/app/scripts/components/sharing/task/SharingListCmp.js b/frontend/app/scripts/components/sharing/task/SharingListCmp.js
@@ -25,6 +25,13 @@
                         org: org
                     });
                 };
+
+                this.cancelRequireAction = function(org) {
+                    this.onCancelRequireAction({
+                        task: self.task,
+                        org: org
+                    });
+                }
             },
             controllerAs: '$ctrl',
             templateUrl: 'views/components/sharing/task/sharing-list.html',
@@ -38,6 +45,7 @@
                 onUpdateProfile: '&',
                 onDelete: '&',
                 onRequireAction: '&',
+                onCancelRequireAction: '&',
                 permissions: '='
             }
         });

diff --git a/frontend/app/scripts/controllers/case/CaseTasksItemCtrl.js b/frontend/app/scripts/controllers/case/CaseTasksItemCtrl.js
@@ -382,7 +382,7 @@
             };
 
             $scope.markShareAsActionRequired = function(task, org) {
-                CaseTaskSrv.promtForActionRequired('Require Action', 'Would you like to add a task log before requesting action?')
+                CaseTaskSrv.promtForActionRequired('Require Action', 'Would you like to add a task log before marking the required action as DONE?')
                     .then(function(response) {
                         if(response === 'skip-log') {
                             return $q.resolve();
@@ -394,11 +394,33 @@
                         return CaseTaskSrv.markAsActionRequired(task._id, org);
                     })
                     .then(function() {
-                        NotificationSrv.log('The task\'s required action flag has been set for organisation ' + org, 'success');
+                        NotificationSrv.log('The task\'s required action is completed', 'success');
                     })
                     .catch(function(err) {
                         if(err && !_.isString(err)) {
-                            NotificationSrv.error('Error', 'Task request action failed', err.status);
+                            NotificationSrv.error('Error', 'Task required action failed to be marked as done', err.status);
+                        }
+                    });
+            };
+
+            $scope.markShareAsActionDone = function(task, org) {
+                CaseTaskSrv.promtForActionRequired('Require Action', 'Would you like to add a task log before marking the required action as DONE?')
+                    .then(function(response) {
+                        if(response === 'skip-log') {
+                            return $q.resolve();
+                        } else {
+                            return $scope.showAddLog('Please add a task log');
+                        }
+                    })
+                    .then(function() {
+                        return CaseTaskSrv.markAsDone(task._id, org);
+                    })
+                    .then(function() {
+                        NotificationSrv.log('The task\'s required action is completed', 'success');
+                    })
+                    .catch(function(err) {
+                        if(err && !_.isString(err)) {
+                            NotificationSrv.error('Error', 'Task required action failed to be marked as done', err.status);
                         }
                     });
             };

diff --git a/frontend/app/views/components/sharing/task/sharing-list.html b/frontend/app/views/components/sharing/task/sharing-list.html
@@ -11,7 +11,7 @@
                 <th>Organisation</th>
                 <th width="250">Profile</th>
                 <th width="160">Shared At</th>
-                <th width="120" class="text-right" if-permission="manageTask" allowed="{{$ctrl.permissions}}"></th>
+                <th width="150" class="text-right" if-permission="manageTask" allowed="{{$ctrl.permissions}}"></th>
                 <th width="80" class="text-right" if-permission="manageShare" allowed="{{$ctrl.permissions}}">Actions</th>
             </thead>
             <tbody>
@@ -43,6 +43,9 @@
                         <span ng-if="!!!share.actionRequired" class="clickable text-primary" ng-click="$ctrl.requireAction(share.organisationName)">
                             <i class="fa fa-exclamation-triangle"></i> Require Action
                         </span>
+                        <span ng-if="!!share.actionRequired" class="clickable text-danger" ng-click="$ctrl.cancelRequireAction(share.organisationName)">
+                            <i class="fa fa-exclamation-triangle"></i> Cancel Request
+                        </span>
                     </td>
 
                     <td class="text-right" if-permission="manageShare" allowed="{{$ctrl.permissions}}">

diff --git a/frontend/app/views/partials/case/case.tasks.item.html b/frontend/app/views/partials/case/case.tasks.item.html
@@ -256,6 +256,7 @@ <h4 class="vpad10 text-primary">Task sharing</h4>
                  shares="shares"
                  read-only="true"
                  on-require-action="markShareAsActionRequired(task, org)"
+                 on-cancel-require-action="markShareAsActionDone(task, org)"
                  on-delete="removeShare(share)"
                  permissions="userPermissions"
                  ></task-sharing-list>