#1264 WIP Added custom fields, tests still fail

TheHive-Project · Feb 25, 2021 · fc4155d · fc4155d
1 parent 2f67146
commit fc4155d
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 3 deletions.
diff --git a/thehive/app/org/thp/thehive/services/CaseSrv.scala b/thehive/app/org/thp/thehive/services/CaseSrv.scala
@@ -334,7 +334,7 @@ class CaseSrv @Inject() (
           .richCustomFields
           .toList
           .toTry { c =>
-            caseCustomFieldSrv.create(CaseCustomField(), richCase.`case`, c.customField)
+            createCustomField(richCase.`case`, EntityIdOrName(c.customField.name), c.value, c.order)
           }
       )
       _ = cases.map(remove(_))

diff --git a/thehive/test/org/thp/thehive/services/CaseSrvTest.scala b/thehive/test/org/thp/thehive/services/CaseSrvTest.scala
@@ -409,7 +409,10 @@ class CaseSrvTest extends PlaySpecification with TestAppBuilder {
         case21.clone().procedure.toSeq.size mustEqual 1
         case22.clone().procedure.toSeq.size mustEqual 2
         case23.clone().procedure.toSeq.size mustEqual 0
-        // TODO CustomFields
+        // CustomFields
+        case21.clone().customFields.toSeq.size mustEqual 0
+        case22.clone().customFields.toSeq.size mustEqual 1
+        case23.clone().customFields.toSeq.size mustEqual 1
 
         for {
           c21     <- case21.clone().getOrFail("Case")
@@ -423,6 +426,7 @@ class CaseSrvTest extends PlaySpecification with TestAppBuilder {
           mergedCase.clone().tasks.toSeq.size mustEqual 3
           mergedCase.clone().observables.toSeq.size mustEqual 3
           mergedCase.clone().procedure.toSeq.size mustEqual 3
+          mergedCase.clone().customFields.toSeq.size mustEqual 2
         }
       }
     }

diff --git a/thehive/test/resources/data/CaseCustomField.json b/thehive/test/resources/data/CaseCustomField.json
@@ -1,4 +1,6 @@
 [
   {"from": "case3", "to": "string1", "stringValue": "string1 custom field"},
-  {"from": "case3", "to": "boolean1", "booleanValue": true}
+  {"from": "case3", "to": "boolean1", "booleanValue": true},
+  {"from": "caseMerge22", "to": "string1", "stringValue": "merge string1"},
+  {"from": "caseMerge23", "to": "boolean1", "booleanValue": true}
 ]