Cosmetic Bug: wrong number of exported observables displayed

[ITServ-DE]

Request Type

Bug

Work Environment

Question	Answer
OS version (server)	Ubuntu
OS version (client)	Windows
TheHive version / git hash	3.4.0-RC1
Package Type	RPM

Problem Description

When exporting a case to MISP, the message after a successful export to MISP is always "The case has been successfully exported with 1 observable(s)", no matter how many observables are connected to the case and no matter wether or not they are IoCs and/or seen.

The message always says: "1 observable(s)"

The Event is correctly created in MISP.

Steps to Reproduce

1. create a case with zero or more observables
2. Hit Share -> Export to MISP
3. Look at the green success message in the bottom-left corner.

TheHive Screenshot:

Event created in MISP:

[nadouani]

Are you sure you did the export just one time? or did you export a first time, then added another IOC and exported again? The number 1 in this case is the number of IOC that has been exported during the last export action.

[ITServ-DE]

I re-tried it, twice, and yes, my bug report is still correct :-)

1. created a new case, added three observables, exported to MISP -> Message exported with 1 observable, no observables in MISP (as they were not marked as IOC in TH)

2. created a new case, added three observables, marked each of them as IoC and sighted, exported to MISP -> Message exported with 1 observable, three observables in MISP

[ITServ-DE]

Just a quick guess:

In CaseExportDialogCtrl.js

[nadouani]

The issue seems to be angular.isObject([]) who is returning true, where it was returning false before :)