Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added actionRequired for tasks #1701

Merged
merged 20 commits into from
Dec 21, 2020
Merged

Added actionRequired for tasks #1701

merged 20 commits into from
Dec 21, 2020

Conversation

rriclet
Copy link
Contributor

@rriclet rriclet commented Dec 7, 2020

The goal of this feature is to allow a user to mark a task as requiring an action from an organisation. This introduces the following changes:

APIs

  • Add GET /api/v1/task/{taskId}/actionRequired to list a map of organisations and their actionRequired flag on the corresponding task
  • Add PUT /api/v1/task/{taskId}/actionRequired/{org} to mark a task actionRequired flag to true for organisation org
  • Add PUT /api/v1/task/{taskId}/actionDone/{org} to mark a a task actionRequired flag to false for organisation org
  • Add a actionRequired extra data to the listCase Query to return true if at least one task of each case, requires an action from the organisation of the current user
  • Add a actionRequired & actionRequiredMap extra data to the listTask Query to return true for each task that requires an action from the organisation of the current user
  • Add a actionRequired extra data to the getTask Query to return true if the task requires an action from the organisation of the current user
  • Add a actionRequiredMap extra data to the getTask Query to return a map of the organisations and their actionRequired flag
  • Add properties to task et case to allow filtering by the actionRequired flag.

User Interface

  • Show an action required flag in case list when possible
  • Show an action required flag in tasks list when possible
  • Show an action required banner in task details page when possible
  • Allow marking a required action as done
  • Allow marking a task's actionRequired flag for any organisation who has access to a given task
  • check manageTask permission to allow write operations related to the actionRequired flag
  • Rely on actionRequiredMap in task details page instead of GET /api/v1/task/{taskId}/actionRequired as route resolve.
  • Check action required filter in case list
  • Check action required filter in task list
  • Show an action required flag in my tasks page if possible
  • Show an action required flag in waiting tasks page if possible
  • Show a modal dialog when marking a task as actionRequired to prompt for a task log
  • Show a modal dialog when removing the actionRequired flag to prompt for a task log

@rriclet rriclet added the TheHive4 TheHive4 related issues label Dec 7, 2020
@nadouani nadouani added this to the 4.0.3 milestone Dec 21, 2020
@nadouani nadouani changed the base branch from develop-th4 to hotfix/4.0.3 December 21, 2020 15:19
@nadouani nadouani changed the base branch from hotfix/4.0.3 to develop-th4 December 21, 2020 15:23
@To-om To-om changed the base branch from develop-th4 to hotfix/4.0.3 December 21, 2020 16:00
@To-om To-om merged commit d2e131c into hotfix/4.0.3 Dec 21, 2020
@To-om To-om deleted the feature-action-required branch December 21, 2020 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request TheHive4 TheHive4 related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants