Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Case description edit button misplaced after description update #2012

Closed
mphbig opened this issue May 3, 2021 · 4 comments
Closed
Assignees
Labels
bug priority:low Low Priority TheHive4 TheHive4 related issues UX
Milestone

Comments

@mphbig
Copy link

mphbig commented May 3, 2021

Request Type

Bug

Work Environment

Question Answer
OS version (server) Debian
OS version (client) Windows 10
Virtualized Env. True
Dedicated RAM 32 GB
vCPU 12
TheHive version / git hash 4.1.4
Package Type DEB
Database Cassandra
Index type Lucene
Attachments storage Local
Browser type & version Latest Chrome and Firefox
Bonus : screen resolution 1920x1080

Problem Description

It is possible to make the edit button for the description field of a case disappear by editing this description field with just a line break.

Steps to Reproduce

  1. Edit the description of a case
  2. Empty everything
  3. Add a line break (which should be the only thing in your description)
  4. Save the description
  5. The pencil is now reachable by just one pixel

Complementary information

Before
2021-05-03 17_26_47-TheHive - Case #175_ Double Two


Editing the description with just a line break
2021-05-03 17_27_12-TheHive - Case #175_ Double Two


Final result (pencil accessible by just a tiny pixel)
2021-05-03 17_27_43-TheHive - Case #175_ Double Two

@mphbig mphbig added TheHive4 TheHive4 related issues bug labels May 3, 2021
@To-om To-om added this to the 4.1.5 milestone May 10, 2021
@nadouani
Copy link
Contributor

I cannot replace your \n with a Not Specified as it's specified actually. Saying the description is blank means we alter your data.

I don't find a valid fix for this :D

@mphbig what would be a good solution here ?

@nadouani nadouani added UX priority:low Low Priority labels May 31, 2021
@mphbig
Copy link
Author

mphbig commented May 31, 2021

An idea could be to make sure the div surrounding the case description is large enough (on the y axis) so the pencil is visible and clicable at all times.
Because it seems it is not working properly when filling the case description with only \n.

How ? Well, I have never touched UI stuff. I got no clue to help you here :(

@nadouani
Copy link
Contributor

nadouani commented Jun 1, 2021

OK I see, and is the following, a valid use case:

when filling the case description with only \n.

:D

@mphbig
Copy link
Author

mphbig commented Jun 1, 2021

No, it is not a valid use case.

nadouani added a commit that referenced this issue Jun 3, 2021
@nadouani nadouani closed this as completed Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug priority:low Low Priority TheHive4 TheHive4 related issues UX
Projects
None yet
Development

No branches or pull requests

3 participants