[Bug] Can't Delete Case Custom Field (contains [ character) After Migration

[nicpenning]

Request Type

Bug

Work Environment

Question	Answer
OS version (server)	Ubuntu
OS version (client)	18
Virtualized Env.	True
Dedicated RAM	8 GB
vCPU	8
TheHive version / git hash	4.1.4, hash of the commit
Package Type	DEB
Database	Cassandra
Index type	Elasticsearch
Attachments storage	Local
Browser type & version	Chrome

Problem Description

When I try to delete a case custom field I get an error which is likely due to using a bracket "[" character.

Steps to Reproduce

1. Create a case custom field with a bracket in it ( "[" or "]")
2. Migrate to TheHive4 from TheHive3
3. Try to delete the custom field in TheHive4

Possible Solutions

Change invalid characters on the migration to valid characters so they can be deleted in the new platform.

[nadouani]

@nicpenning updating the custom field names silently during the migration is not an option as it changes the data. We will try to find a way to bypass the special character constraint during the delete.

Recommendation: next time you create a custom field, use a domain-password-reset-phishing style. TheHive GUI will help you for it ;)

[nadouani]

@To-om can you please help investigate the custom field deletion in this case. I was not able to reproduce as TheHive 4 doesn't allow the creation of such a name :)

[nadouani]

@To-om I'll try using the custom field's ID for deletion instead of the name, if possible.

[nadouani]

Well, let me answer myself: I can fix it by just using the custom field id instead of the internal name :)

[nicpenning]

That was fast, thank you! You would think I would have learned by now that I shouldn't use such characters when creating these things :)