Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Deleting observables doesn't produce audit log #2076

Closed
nadouani opened this issue Jun 10, 2021 · 3 comments
Closed

[Bug] Deleting observables doesn't produce audit log #2076

nadouani opened this issue Jun 10, 2021 · 3 comments
Assignees
Labels
bug TheHive4 TheHive4 related issues
Milestone

Comments

@nadouani
Copy link
Contributor

Request Type

Bug

Work Environment

Question Answer
TheHive version / git hash 4.1.5
Package Type From source
Database BerlkelyDB
Index type Lucene

Problem Description

Deleting an observable doesn't:

  • produce audit log entry
  • produce stream events
@nadouani nadouani added bug TheHive4 TheHive4 related issues labels Jun 10, 2021
@nadouani
Copy link
Contributor Author

@To-om @vdebergue can this be handled in 4.1.6?

@nadouani nadouani added this to the 4.1.6 milestone Jun 10, 2021
@vdebergue
Copy link
Contributor

Seems a bit hard for my skills right now.

From what I saw and guessed, it seems like there is a visibility problem with the Audit entity in the case of a deletion of an Observable: before sending the audit to the user, we check if it's visible to the user. But as the observable was deleted, the audit is marked as not visible.

Maybe @To-om will know more how to fix this

@nadouani
Copy link
Contributor Author

Makes sense, I think the issue is solved for the tasks, so it should be doable for observables as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug TheHive4 TheHive4 related issues
Projects
None yet
Development

No branches or pull requests

3 participants