Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attachments with character "#" in the filename are wrongly proceesed #645

Closed
crackytsi opened this issue Jul 20, 2018 · 1 comment
Closed

Attachments with character "#" in the filename are wrongly proceesed #645

crackytsi opened this issue Jul 20, 2018 · 1 comment
Assignees
@To-om
Labels
bug
Milestone
3.1.0-RC1 (Cerana 1)

Comments

@crackytsi
Copy link

crackytsi commented Jul 20, 2018 •
edited
Loading

Request Type

Bug

Work Environment

Question Answer
OS version (server) Debian
OS version (client) Seven,
TheHive version / git hash 3.0.10
Package Type DEB
Browser type & version Firefox, Chrome

Problem Description

When I attache a file with the chracter "#" in the filename, during download it is trying to downliad a the filename replacing # with -. The contents is valid and complete, but the extension also disappears.

Possible Solutions

Prevent this filename or if there is a solution handle it correct.
@To-om
Copy link
Contributor

To-om commented Jul 25, 2018

It occurs because # character is not correctly encoded.
@nadouani can you urlencode file name before send it to backend ?

@To-om To-om added the bug label Jul 25, 2018
@To-om To-om added this to the 3.1.0 (Cerana 1) milestone Jul 25, 2018
nadouani added a commit that referenced this issue Jul 26, 2018
@nadouani
#645 Escape the attachment file name when buildng file download urls
f79a11f
@nadouani nadouani assigned To-om and unassigned nadouani Jul 26, 2018
To-om added a commit that referenced this issue Jul 26, 2018
@To-om
#645 Don't reencode file name in backend
f4ff150
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@To-om To-om

Labels
bug
Projects
None yet
Milestone
3.1.0-RC1 (Cerana 1)
Development

No branches or pull requests
3 participants
@nadouani @crackytsi @To-om