Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drone build fails on pull-requests #882

Closed
To-om opened this issue Feb 18, 2019 · 0 comments
Closed

Drone build fails on pull-requests #882

To-om opened this issue Feb 18, 2019 · 0 comments
Assignees
@To-om
Labels
bug
Milestone
3.3.0 RC3

Comments

@To-om
Copy link
Contributor

To-om commented Feb 18, 2019

Request Type

Bug

Problem Description

Continuous integration tries to deploy application on test server. For security reason, secrets are not available when building PR. So deployment fails and the whole build fails too.

Possible Solutions

Disable deployment if secrets are not available.
@To-om To-om added the bug label Feb 18, 2019
@To-om To-om added this to the 3.3.0 RC3 milestone Feb 18, 2019
@To-om To-om self-assigned this Feb 18, 2019
To-om added a commit that referenced this issue Feb 19, 2019
@To-om
#882 Disable deployment on pull-requests
a51f6d9
To-om added a commit that referenced this issue Feb 19, 2019
@To-om
#882 Disable deployment on pull-requests
3dce91a
@To-om To-om closed this as completed Feb 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@To-om To-om

Labels
bug
Projects
None yet
Milestone
3.3.0 RC3
Development

No branches or pull requests
1 participant
@To-om