-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature taxonomy #1668
Merged
Merged
Feature taxonomy #1668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rriclet
commented
Nov 18, 2020
rriclet
commented
Nov 18, 2020
.property("namespace", UMapping.string)(_.field.readonly) | ||
.property("description", UMapping.string)(_.field.readonly) | ||
.property("version", UMapping.int)(_.field.readonly) | ||
// Predicates ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there other public properties to add ?
To-om
requested changes
Nov 19, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job !
thehive/app/org/thp/thehive/models/TheHiveSchemaDefinition.scala
Outdated
Show resolved
Hide resolved
20 tasks
To-om
requested changes
Dec 8, 2020
thehive/app/org/thp/thehive/models/TheHiveSchemaDefinition.scala
Outdated
Show resolved
Hide resolved
Also, taxonomyCtrl should be included in describeCtrl. |
…ies & added enabled property
…on, enable/disable, delete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Import taxonomies as a zip file
Formatting
Each taxonomy must be placed in a .json file.
Name the .zip file and .json files as you like.
The format of each JSON taxonomy must comply with the MISP taxonomy format, found here :
https://tools.ietf.org/id/draft-dulaunoy-misp-taxonomy-format-04.html
Usage
When calling the API, you must specify a
file
attribute. An example with the curl command below :curl -u user:password -F file=@zipPath server/api/v1/taxonomy/import-zip
Errors
If you import a taxonomy which namespace is already in your organisation : the API will respond an error with the guilty namespace inside and no taxonomy will be added to your organisation.
If files inside .zip file are not JSON MISP formatted files : the API will respond an error with the guilty file inside and no taxonomy will be added to your organisation.