Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change layout of observable creation form #706

Merged
merged 2 commits into from
Sep 4, 2018
Merged

Change layout of observable creation form #706

merged 2 commits into from
Sep 4, 2018

Conversation

srilumpa
Copy link

@srilumpa srilumpa commented Sep 4, 2018

Hi,

This is a simple proposal of an improvement for the observable creation form (or so I think).

Just in case, this is the current layout:
original

The issue for me is that, if you follow the layout, you will activate the bulk form only after having tried to input a new observable. After putting some thinking into it, it seems to me that the capacity to toggle off the bulk imports does not bring that much. So, I made it the only behavior when importing observables that are not files. After all, importing only one observable is importing a bulk of one element.

I used the opportunity to also change the setting of the IOC and sighted attributes to keep consistency between the observable creation and detail pages.

  • Always importing observables in bulk (even a bulk of one element)
  • Using the same layout from the observable details page in the
    observable creation form
  • Keep labels aligned with data (sorry, I am slightly psycho-rigid on that kind of stuff)

So here is the result:
proposal

I have tested:

  • import of a single observable (not a file)
  • import of several observables at once (not files)
  • import of a file

using various combinations of the IOC or sighted attribute.

Do not hesitate if you have some feedback to make about it.

* Always importing observables in bulk (even a bulk of one element)
* Using the same layout from the observable details page in the
observable creation form
* Keep labels aligned with data
@nadouani
Copy link
Contributor

nadouani commented Sep 4, 2018

Hello, I'll review this, can you just update your branch and to remove the conflicts with develop branch?

Thanks

@srilumpa
Copy link
Author

srilumpa commented Sep 4, 2018

Sorry I haven't noticed those conflicts before creating the pull request. They should be solved now.

@nadouani nadouani added this to the 3.1.0-RC3 milestone Sep 4, 2018
@nadouani
Copy link
Contributor

nadouani commented Sep 4, 2018

Sorry I haven't noticed those conflicts before creating the pull request. They should be solved now.

Oh, not a problem at all :)

@saadkadhi
Copy link
Contributor

Good improvement. Let's take it! Thanks @srilumpa

@nadouani nadouani merged commit be99498 into TheHive-Project:develop Sep 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants