-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Critical Severity #926
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This may actually start to cover #11 |
@zpriddy Hi, Thanks for adding so many interesting PRs. Unforunately it seems that your PRs aren't seperated, so the new status and critical severity are combined. |
Yeah I noticed that. I can split those out.
…On Tue, Mar 19, 2019 at 2:01 PM crackytsi ***@***.***> wrote:
@zpriddy <https://github.com/zpriddy> Hi, Thanks for adding so many
interesting PRs. Unforunately it seems that your PRs aren't seperated, so
the new status and critical severity are combined.
Are you able to split that?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#926 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABxcd7VZkOG3VgBUWq0O1dFd_V_UARnnks5vYVAdgaJpZM4b10nB>
.
|
Merged
Replacing with #939 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a 4th severity of Critical. This is very helpful if you want to trigger pages off of only Critical Alerts or Cases
This does change the color of items so there may want to be some talk around it