Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#388 - Enhance session's error parse method #393

Merged
merged 1 commit into from
Feb 16, 2025
Merged

#388 - Enhance session's error parse method #393

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions thehive4py/session.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,8 +141,13 @@
except requests.exceptions.JSONDecodeError:
json_data = None

if json_data is None:
error_text = response.text
else:
if isinstance(json_data, dict) and all(
[
"type" in json_data,
"message" in json_data,
]
):
error_text = f"{json_data['type']} - {json_data['message']}"
else:
error_text = response.text

Check warning on line 152 in thehive4py/session.py

View check run for this annotation

Codecov / codecov/patch

thehive4py/session.py#L152 

Added line #L152 was not covered by tests
raise TheHiveError(message=error_text, response=response)