Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix InputAnalyzerJob type and add regression test #397

Conversation

JuanTecedor
Copy link
Contributor

As per #395, this PR swaps the observableId field with the articfactId field and adds a regression test.

@JuanTecedor JuanTecedor marked this pull request as ready for review February 17, 2025 17:11
Copy link

codecov bot commented Feb 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.37%. Comparing base (3dc1a88) to head (58580ab).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #397      +/-   ##
==========================================
+ Coverage   93.24%   93.37%   +0.12%     
==========================================
  Files          28       28              
  Lines         785      785              
==========================================
+ Hits          732      733       +1     
+ Misses         53       52       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Kamforka Kamforka merged commit 8ee2248 into TheHive-Project:main Feb 17, 2025
13 checks passed
@Kamforka
Copy link
Collaborator

Thank you! 🙏

@JuanTecedor
Copy link
Contributor Author

Happy to help 😄, sorry for the confusion earlier!

@Kamforka Kamforka added 2.x changelog:fixed changelog label for any bug fixes labels Feb 21, 2025
@Kamforka Kamforka added this to the 2.0.0b9 milestone Feb 21, 2025
@Kamforka Kamforka self-requested a review February 21, 2025 15:58
@Kamforka Kamforka linked an issue Feb 21, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x changelog:fixed changelog label for any bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Cortex's InputAnalyzerJob type
2 participants