Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Renaming Source properties #91

Merged
merged 2 commits into from
Nov 14, 2019
Merged

refactor: Renaming Source properties #91

merged 2 commits into from
Nov 14, 2019

Conversation

amis92
Copy link
Member

@amis92 amis92 commented Nov 14, 2019

  • EntryBase: IsHidden -> Hidden
  • SelectionEntryBase: Import -> Exported
  • Category: IsPrimary -> Primary
  • CategoryLink: IsPrimary -> Primary
  • SelectorBase: PercentValue -> IsValuePercentage
  • Repeat:
    • Repeats -> RepeatCount
    • IsRoundUp -> RoundUp

Also added some xml documentation comments.

closes #87

- EntryBase: IsHidden -> Hidden
- SelectionEntryBase: Import -> Exported
- Category: IsPrimary -> Primary
- CategoryLink: IsPrimary -> Primary
- SelectorBase: PercentValue -> IsValuePercentage
- Repeat:
  - Repeats -> RepeatCount
  - IsRoundUp -> RoundUp

Also added some xml documentation comments.

closes #87
@amis92 amis92 added this to the 0.8 milestone Nov 14, 2019
@amis92 amis92 self-assigned this Nov 14, 2019
@amis92 amis92 merged commit c174594 into master Nov 14, 2019
@amis92 amis92 deleted the fix/property-names branch November 14, 2019 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix naming of properties in Source
1 participant