add $divfloor support to write_smt2 #3335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The additions to write_smt2 look good to me. Making yices a hard dependency for |
programmerjake
added a commit
to programmerjake/sby
that referenced
this pull request
May 25, 2022
programmerjake
force-pushed
the
divfloor-in-write_smt2
branch
from
8e5e9ef to
d53479a
Compare
|
I moved the test to YosysHQ/sby#161, does it look good now? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3330
Also adds a simple test that
$divfloorand$modflooractually work correctly, though it does require yices to run...