Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

From Issue 'Add the Fibonacci Search Algorithm with example and explanation #56' #87

Merged

Conversation

JoseNNeto
Copy link
Contributor

Summary

This PR adds the Fibonacci Search Algorithm with examples and easy-to-understand explanations.

Changes

-Added the FibonacciSearch.java file containing the search algorithm along with its execution in the main function.
-Added the FibonacciSearch.md file, which explains how the algorithm works and provides details about the search itself.

Issue

Add the Fibonacci Search Algorithm with example and explanation #56

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing in the project for the first time, don't stop yourself and keep on contributing, your pull request will be reviewed soon

@abhishektripathi66
Copy link
Owner

Hi @JoseNNeto,

There are some .md related issues in this PR, please address them and we will merge it.

@abhishektripathi66
Copy link
Owner

Looks all good

@abhishektripathi66 abhishektripathi66 merged commit ccaefe4 into abhishektripathi66:master Jan 31, 2025
9 of 13 checks passed
@JoseNNeto
Copy link
Contributor Author

Thank you for being considerate of my PR. After purchasing the book Grokking Algorithms, I became an enthusiast on the subject, what you are doing through your repository is very important to help programmers.

If you don't see a problem with someone making multiple PRs, I'm interested in making others to resolve more of the issues that were added.

@abhishektripathi66
Copy link
Owner

Hi @JoseNNeto,

I'm trying to creating all in one repo for the DSA, where in anyone can learn the concept as well as get the examples for the same and some questions as well.

Yes, you can go ahead and create multiple PRs, if you regular on coding and even reviewing the code of others I can make you my fellow collaborator.

Happy coding

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the Fibonacci Search Algorithm with example and explanation
2 participants