Fix several typos and bugs

[HirokiHamaguchi]

Pull Request

Hello. I'm Hiroki Hamaguchi and I'm really impressed with this repository.
Thank you very much for providing such a wonderful template.

Today, I'd like to contribute to this repository by fixing some problems.
I hope my contribution will be helpful to you.

If you have any questions or concerns, please feel free to ask me.

Fix typos of GitHub

This repository contains 44 instances of "GitHub" and 8 instances of "Github", including the author profile.

The correct spelling is "GitHub".

I fixed all of the "Github" to "GitHub", and confirmed that no issues occurred by checking all affected pages.

Fix link in talkmap.html

The Talk Map contains a hyperlink to the talkmap.ipynb file, but this link is broken.

I fixed the link to the correct file path.

I checked that the link is now working properly, and the updated path is also consistent with the following sentence in talkmap.html.

Since other links pointing to the talkmap.ipynb were correct, I did not change them.

Fix the clock icons by fa-clock

The clock icon is not displayed correctly.

The icon fa-clock-o was available in Font Awesome version 4, but now it seems to be removed in the current version.

• Font Awesome Version 4 - fa-clock-o
• Stack Overflow discussion

Instead, we can use fa-clock in current version, which works fine.

I replaced all 8 instances of fa-clock-o with fa-clock, and checked that the icon is now displayed correctly.

Fix the right-sidebar

As pointed out in this discussion, there are blank area in the right hand side of the page.

I think this is not intentional, because this space was originally used for the right sidebar as seen in the Minimal Mistakes, rather than the blank area.

To resolve this, as pointed out in the discussion, we can modify $right-sidebar-width-narrow, $right-sidebar-width, and $right-sidebar-width-wide in the SCSS file _sass/_variables.scss.

The side-effect of this modification is that the behavior of .sidebar__right in _sass/_sidebar.scss will be changed, but it seems not to be used anywhere in the current version. Therefore, I think this modification is safe.

To maintain the original design, I adjusted them by scaling the values by 0.1, not 0.0 (0.0 might be too narrow).

- $right-sidebar-width-narrow : 200px !default;
- $right-sidebar-width        : 300px !default;
- $right-sidebar-width-wide   : 400px !default;
+ $right-sidebar-width-narrow : 20px !default;
+ $right-sidebar-width        : 30px !default;
+ $right-sidebar-width-wide   : 40px !default;

Now, the space is removed, and there is no problem with the design.

Fix site-nav problem in jquery.greedy-navigation.js

Issue Description

First, let me explain the problem itself. As far as I know, there are no issues with this point.

For the sake of explanation, the device mode is used. I actually had this problem on my iPad. The same problem can be easily reproduced in a browser.

Then, simulate the rotation of the device.

Again, simulate the rotation of the device.

Now, although there is enough space, the site-nav bar only displays one item, not three items as before.

Solution

This is because the assets/js/plugins/jquery.greedy-navigation.js contains a bug.

The most important part of my fix is the following.

// There is space for another item in the nav
- if(availableSpace > breaks[breaks.length-1]) {
+ while(breaks.length > 0 && availableSpace > breaks[breaks.length-1]) {
  // Move the item to the visible list
  $hlinks.children().first().appendTo($vlinks);
  breaks.pop();
}

// Hide the dropdown btn if hidden list is empty
if(breaks.length < 1) {
  $btn.addClass('hidden');
+   $btn.removeClass('close');
  $hlinks.addClass('hidden');
}

Plus, I added the event listener to update the site-nav when the orientation is changed, which cannot be done by the original code.

+ screen.orientation.addEventListener("change", function() {
+   updateNav();
+ });

Verification

I build the code and confirmed that now the problem is solved without any side effects, as far as I checked.

---

Thank you for reading this long message.

I hope my contribution will be helpful to you.

[rjzupkoii]

Great work with these changes!

[rjzupkoii]

Thanks for putting this merge together and documenting all of the work done. This is a big help and as you pointed out, addresses issues like #2473.