Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docsy theme #28

Merged
merged 2 commits into from
Apr 8, 2024
Merged

Update docsy theme #28

merged 2 commits into from
Apr 8, 2024

Conversation

LorenzBischof
Copy link
Contributor

@LorenzBischof LorenzBischof commented Apr 4, 2024

I did some light testing and everything seems to work. We can probably merge this and slowly migrate and test the trainings.

@splattner
Copy link
Member

Did you remove the "copy" button by intention?

@LorenzBischof
Copy link
Contributor Author

Yes. That was added in Docsy 0.5.1: google/docsy#1245 You can test the new theme by adding replacements in the hugo-training-template.

@LorenzBischof
Copy link
Contributor Author

Do you need my help with testing and deploying? If not, feel free to merge.

@splattner splattner merged commit 601223b into main Apr 8, 2024
@splattner splattner deleted the upgrade branch April 8, 2024 10:39
@splattner
Copy link
Member

splattner commented Apr 8, 2024

I merged, do yo mind also updating and testing it in acend/hugo-training-template#302 and acend/hugo-training-template#301 ?
when its fine there, I think I'll be able to apply the necessary changes to all our other repos.

@schlapzz also said in our internal chat

Bei PR301 müsste man wohl die Color Vars anpassen (gray-X) sind im SCSS von Docsy 0.9.1 nicht mehr vorhanden... Wir haben aber in unseren SCSS z.B. docsy-acend) noch diverse Referenzen auf diese Farben. (Siehe hier: https://github.com/acend/docsy-plus/blob/main/assets/scss/site.scss#L33)

@LorenzBischof
Copy link
Contributor Author

LorenzBischof commented Apr 8, 2024

gray-300 is a bootstrap variable. I changed the implementation a bit and it should work again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants