Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove learner member from endpointsFromCluster #28

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Conversation

git-yww
Copy link
Contributor

@git-yww git-yww commented Oct 19, 2023

Fix #26

@ahrtr
Copy link
Owner

ahrtr commented Oct 19, 2023

a quick question, have you verified this PR in your test that you mentioned in #26 (comment)?

@git-yww
Copy link
Contributor Author

git-yww commented Oct 19, 2023

a quick question, have you verified this PR in your test that you mentioned in #26 (comment)?

Yes,it did work.

@ahrtr
Copy link
Owner

ahrtr commented Oct 19, 2023

please squash the commits into one.

@git-yww
Copy link
Contributor Author

git-yww commented Oct 19, 2023

please squash the commits into one.

resolved

Copy link
Owner

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you @git-yww

@ahrtr
Copy link
Owner

ahrtr commented Oct 19, 2023

Can you please add an item under https://github.com/ahrtr/etcd-defrag#note something like below?

Please do not get learner members' endpoints included in `--endpoints`,  refer to discussion in https://github.com/ahrtr/etcd-defrag/issues/26.

@git-yww
Copy link
Contributor Author

git-yww commented Oct 19, 2023

Absolutely. That's a good point.

@git-yww
Copy link
Contributor Author

git-yww commented Oct 19, 2023

Due to that one etcd cluster only supports one learner member, so the item to add will be like:
Please do not get learner member endpoint included in --endpoints, refer to discussion in https://github.com/ahrtr/etcd-defrag/issues/26.

@ahrtr
Copy link
Owner

ahrtr commented Oct 19, 2023

The default maxLearner is 1, but actually it's configurable via the flag --experimental-max-learners, so let's use the plural noun.

@ahrtr
Copy link
Owner

ahrtr commented Oct 19, 2023

Thanks again! Nice work!

@ahrtr ahrtr merged commit bcec0ac into ahrtr:main Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

etcd cluster with a learner is not supported
2 participants