-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove learner member from endpointsFromCluster #28
Conversation
a quick question, have you verified this PR in your test that you mentioned in #26 (comment)? |
Yes,it did work. |
please squash the commits into one. |
resolved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you @git-yww
Can you please add an item under https://github.com/ahrtr/etcd-defrag#note something like below?
|
Absolutely. That's a good point. |
Due to that one etcd cluster only supports one learner member, so the item to add will be like: |
The default maxLearner is 1, but actually it's configurable via the flag |
Thanks again! Nice work! |
Fix #26