Add leader transfer logic #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahrtr
reviewed
Jan 26, 2025
|
could you please also update the readme? |
ahrtr
reviewed
Jan 27, 2025
| @@ -39,6 +39,7 @@ It adds the following extra flags, | |||
| | `--defrag-rule` | defragmentation rule (etcd-defrag will run defragmentation if the rule is empty or it is evaluated to true), defaults to empty. See more details below. | | |||
| | `--dry-run` | evaluate whether or not endpoints require defragmentation, but don't actually perform it, defaults to `false`. | | |||
| | `--exclude-localhost` | whether to exclude localhost endpoints, defaults to `false`. | | |||
| | `--move-leader` | whether to move the leader to a randomly picked non-leader ID and make it the new leader, defaults to `false`. | | |||
There was a problem hiding this comment.
Suggested change
| | `--move-leader` | whether to move the leader to a randomly picked non-leader ID and make it the new leader, defaults to `false`. | | |
| | `--move-leader` | whether to move the leader to another follower before performing defragment on it to minimize potential performance impact, defaults to `false`. | |
| @@ -70,6 +71,7 @@ Flags: | |||
| --keepalive-time duration keepalive time for client connections (default 2s) | |||
| --keepalive-timeout duration keepalive timeout for client connections (default 6s) | |||
| --key string identify secure client using this TLS key file | |||
| --move-leader whether to move the leader to a randomly picked non-leader ID and make it the new leader | |||
There was a problem hiding this comment.
ditto, please update the description
| @@ -24,6 +24,7 @@ func newDefragCommand() *cobra.Command { | |||
| defragCmd.Flags().StringSliceVar(&globalCfg.endpoints, "endpoints", []string{"127.0.0.1:2379"}, "comma separated etcd endpoints") | |||
| defragCmd.Flags().BoolVar(&globalCfg.useClusterEndpoints, "cluster", false, "use all endpoints from the cluster member list") | |||
| defragCmd.Flags().BoolVar(&globalCfg.excludeLocalhost, "exclude-localhost", false, "whether to exclude localhost endpoints") | |||
| defragCmd.Flags().BoolVar(&globalCfg.moveLeader, "move-leader", false, "whether to move the leader to a randomly picked non-leader ID and make it the new leader") | |||
There was a problem hiding this comment.
ditto, please update the description
Comment on lines
+235
to
+238
| defer c.Close() | ||
|
|
||
| ctx, cancel := commandCtx(gcfg.commandTimeout) | ||
| defer cancel() |
There was a problem hiding this comment.
minor comment
Suggested change
| defer c.Close() | |
| ctx, cancel := commandCtx(gcfg.commandTimeout) | |
| defer cancel() | |
| ctx, cancel := commandCtx(gcfg.commandTimeout) | |
| defer func() { | |
| c.Close() | |
| cancel() | |
| }() |
| ctx, cancel := commandCtx(gcfg.commandTimeout) | ||
| defer cancel() | ||
|
|
||
| fmt.Printf("Requesting leader at %s to transfer leadership to member ID %d...\n", leaderEp, transfereeID) |
There was a problem hiding this comment.
Suggest not to print log in this utility function, please print log in main.go only if needed
Suggested change
| fmt.Printf("Requesting leader at %s to transfer leadership to member ID %d...\n", leaderEp, transfereeID) |
| return fmt.Errorf("failed to move leader: %w", err) | ||
| } | ||
|
|
||
| fmt.Println("successfully transferred leadership from", leaderEp, "to member ID ", transfereeID) |
There was a problem hiding this comment.
ditto
Suggested change
| fmt.Println("successfully transferred leadership from", leaderEp, "to member ID ", transfereeID) |
ahrtr
approved these changes
Jan 27, 2025
|
Refer to 5b38140 It also fixed a bug in this PR. When there is only one member in the cluster, we shouldn't move leader at all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--move-leaderflag.--continue-on-errorflag.This change mitigates the risk of outages caused by defragmenting the leader node in an etcd cluster.
Resolves #58