[PR #5278/0f0c3759 backport][3.10] Drop Python 3.6 support #8512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdraco
force-pushed
the
patchback/backports/3.10/0f0c3759616e5369403cd711d8ff898c28f38548/pr-5278
branch
2 times, most recently
from
76c0843 to
c989e29
Compare
psf-chronographer
bot
added
the
bot:chronographer:provided
bdraco
changed the title
(cherry picked from commit 0f0c375)
bdraco
force-pushed
the
patchback/backports/3.10/0f0c3759616e5369403cd711d8ff898c28f38548/pr-5278
branch
from
c989e29 to
e28da47
Compare
|
This is a missed backport |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 3.10 #8512 +/- ##
==========================================
+ Coverage 97.46% 97.47% +0.01%
==========================================
Files 108 108
Lines 33430 33406 -24
Branches 4010 4005 -5
==========================================
- Hits 32583 32563 -20
+ Misses 619 617 -2
+ Partials 228 226 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
webknjaz
reviewed
Jul 17, 2024
bdraco
added
bot:chronographer:skip
bdraco
deleted the
patchback/backports/3.10/0f0c3759616e5369403cd711d8ff898c28f38548/pr-5278
branch
This was referenced Jul 30, 2024
dcermak
added a commit
to dcermak/py-obs
that referenced
this pull request
Aug 2, 2024
Previously we were storing a ClientSession as a class attribute of Osc. However as of aio-libs/aiohttp#8512 that breaks, as aiohttp.ClientSessions require a running asyncio event loop, which is not guaranteed to exist. Instead we recreate a session inside a api_request which is an async function and is guaranteed to have a running event loop.
dcermak
added a commit
to dcermak/py-obs
that referenced
this pull request
Aug 2, 2024
Previously we were storing a `ClientSession` as a class attribute of `Osc`. However as of aio-libs/aiohttp#8512 that breaks, as `aiohttp.ClientSession` requires a running asyncio event loop, which is not guaranteed to exist. Instead we recreate a session inside `api_request` which is an async function and is guaranteed to have a running event loop.
dcermak
added a commit
to dcermak/py-obs
that referenced
this pull request
Aug 2, 2024
Previously we were storing a `ClientSession` as a class attribute of `Osc`. However as of aio-libs/aiohttp#8512 that breaks, as `aiohttp.ClientSession` requires a running asyncio event loop, which is not guaranteed to exist. Instead we recreate a session inside `api_request` which is an async function and is guaranteed to have a running event loop.
dcermak
added a commit
to dcermak/py-obs
that referenced
this pull request
Aug 2, 2024
Previously we were storing a `ClientSession` as a class attribute of `Osc`. However as of aio-libs/aiohttp#8512 that breaks, as `aiohttp.ClientSession` requires a running asyncio event loop, which is not guaranteed to exist. Instead we recreate a session inside `api_request` which is an async function and is guaranteed to have a running event loop.
cthulhustig
added a commit
to cthulhustig/autojimmy
that referenced
this pull request
Aug 7, 2024
Proxy was failing to start with the error below when using aiohttp 3.10.
```
Traceback (most recent call last):
File "E:\Projects\autojimmy\proxy\mapproxy.py", line 325, in _serviceCallback
requestHandler = proxy.RequestHandler(
^^^^^^^^^^^^^^^^^^^^^
File "E:\Projects\autojimmy\proxy\requesthandler.py", line 102, in __init__
self._connector = aiohttp.TCPConnector(
^^^^^^^^^^^^^^^^^^^^^
File "C:\Users\GrooveStar\AppData\Local\Programs\Python\Python311\Lib\site-packages\aiohttp\connector.py", line 784, in __init__
super().__init__(
File "C:\Users\GrooveStar\AppData\Local\Programs\Python\Python311\Lib\site-packages\aiohttp\connector.py", line 234, in __init__
loop = loop or asyncio.get_running_loop()
^^^^^^^^^^^^^^^^^^^^^^^^^^
RuntimeError: no running event loop
An exception occurred while starting the proxy
File "E:\Projects\autojimmy\jobs\startupjobs.py", line 33, in run
self.executeJob()
proxy.MapProxy.instance().start(
File "E:\Projects\autojimmy\proxy\mapproxy.py", line 161, in start
raise RuntimeError(f'Map proxy failed to start ({message[1]})')
RuntimeError: Map proxy failed to start (no running event loop)
```
The issue was triggered by [this aiohttp
PR](aio-libs/aiohttp#8512) which changed
behaviour so that some classes must now be explicitly passed a loop at
construction if there isn't one currently running.
5 tasks
dcermak
added a commit
to dcermak/openapi-generator
that referenced
this pull request
Dec 11, 2024
…nit__ aiohttp's `ClientSession` & `TCPConnector` used to obtain an event loop in __init__ (via `asyncio.get_event_loop`). However, as of aio-libs/aiohttp#8512 both classes now obtain the running event loop and won't potentially create one. This makes it impossible to create `ClientSession` and `TCPConnector` objects outside of coroutines, as `get_running_loop` must be called from a coroutine. Thus we defer the creation of a `ClientSession` into the actual request and cache it for later usage. Thereby we pay only a very small price on the first request, but subsequent requests will not be any more expensive.
dcermak
added a commit
to dcermak/openapi-generator
that referenced
this pull request
Dec 11, 2024
…nit__ aiohttp's `ClientSession` & `TCPConnector` used to obtain an event loop in __init__ (via `asyncio.get_event_loop`). However, as of aio-libs/aiohttp#8512 both classes now obtain the running event loop and won't potentially create one. This makes it impossible to create `ClientSession` and `TCPConnector` objects outside of coroutines, as `get_running_loop` must be called from a coroutine. Thus we defer the creation of a `ClientSession` into the actual request and cache it for later usage. Thereby we pay only a very small price on the first request, but subsequent requests will not be any more expensive.
wing328
pushed a commit
to OpenAPITools/openapi-generator
that referenced
this pull request
Dec 15, 2024
…nit__ (#20292) aiohttp's `ClientSession` & `TCPConnector` used to obtain an event loop in __init__ (via `asyncio.get_event_loop`). However, as of aio-libs/aiohttp#8512 both classes now obtain the running event loop and won't potentially create one. This makes it impossible to create `ClientSession` and `TCPConnector` objects outside of coroutines, as `get_running_loop` must be called from a coroutine. Thus we defer the creation of a `ClientSession` into the actual request and cache it for later usage. Thereby we pay only a very small price on the first request, but subsequent requests will not be any more expensive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 0f0c375)