Adding test cases for Non object + object mapping error #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -546,7 +546,7 @@ private static boolean tryRegisterField( | |||
| new CompressedXContent(BytesReference.bytes(mapping)), | |||
| MapperService.MergeReason.MAPPING_UPDATE); | |||
| } catch (Exception e) { | |||
| LOG.error("Error doing map update errorMsg={}", e.getMessage()); | |||
| LOG.warn("Error doing map update errorMsg={}", e.getMessage()); | |||
There was a problem hiding this comment.
I think it would be good if this error message highlighted
- That this is for mappings used by aggregations
- What field is impacted
It could also pass the exception again as a dangling argument so the stacktrace and class are reported.
astra/src/test/java/com/slack/astra/logstore/opensearch/ObjectMapperTest.java
Outdated
Show resolved
Hide resolved
astra/src/test/java/com/slack/astra/logstore/opensearch/ObjectMapperTest.java
Outdated
Show resolved
Hide resolved
astra/src/test/java/com/slack/astra/logstore/opensearch/ObjectMapperTest.java
Outdated
Show resolved
Hide resolved
astra/src/test/java/com/slack/astra/logstore/opensearch/ObjectMapperTest.java
Outdated
Show resolved
Hide resolved
astra/src/test/java/com/slack/astra/logstore/opensearch/ObjectMapperTest.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding test cases for Non object + object mapping error
To test out the error seen on index node:
Error doing map update errorMsg=can't merge a non object mapping [alerts] with an object mappingThe error is seen when the same parent field is being used as object and non-object. When this happens, the aggregation operation fails on for the parent object. The document will still be inserted.
Currently, we are not doing very complex aggregation. So as far as we are not dropping the document, we are okay to proceed so moving the log level also to warning for the error message.
Requirements