Clarify Rule: Never use the default case when switching over an enum #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary This PR proposes clarifying the rule "Never use the default case when switching over an enum" to be more specific. Reasoning I clarified rule with "real world" example and to follow clear and understandable examples that the guide is providing. (such as universe, weather and etc.) Open to suggestions on this, thanks! 😄 Reviewers cc. @calda Please react with 👍/👎 if you agree or disagree with this proposal.
calda
approved these changes
Mar 20, 2023
README.md
Outdated
| default: | ||
| // Do something else. | ||
| // Stop your vehicle | ||
| } | ||
|
|
||
| // RIGHT | ||
| switch anEnum { |
There was a problem hiding this comment.
Should this be switch trafficLight {?
There was a problem hiding this comment.
You are right. Thank you so much for pointing out. Fixed it accordingly.
@calda Please review again. 😃
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR proposes clarifying the rule of "Never use the default case when switching over an enum" to be more specific.
Reasoning
I clarified rule with "real world" example and to follow clear and understandable examples that the guide is providing. (such as universe, weather and etc.)
Please review. Thanks! 😄
Reviewers
cc. @calda
Please react with 👍/👎 if you agree or disagree with this proposal.