Fix typos in README.md #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calda
reviewed
Apr 6, 2023
README.md
Outdated
| @@ -1569,7 +1569,7 @@ _You can enable the following settings in Xcode by running [this script](resourc | |||
|
|
|||
| ## Patterns | |||
|
|
|||
| * <a id='implicitly-unwrapped-optionals'></a>(<a href='#implicitly-unwrapped-optionals'>link</a>) **Prefer initializing properties at `init` time whenever possible, rather than using implicitly unwrapped optionals.** A notable exception is UIViewController's `view` property. [](https://realm.github.io/SwiftLint/implicitly_unwrapped_optional) | |||
| * <a id='implicitly-unwrapped-optionals'></a>(<a href='#implicitly-unwrapped-optionals'>link</a>) **Prefer initializing properties at `init` whenever possible, rather than using implicitly unwrapped optionals.** A notable exception is UIViewController's `view` property. [](https://realm.github.io/SwiftLint/implicitly_unwrapped_optional) | |||
There was a problem hiding this comment.
This was correct before. We would want this to be either "at init time" like it was before , or "in init". I don't think "at init" makes sense.
There was a problem hiding this comment.
@calda Thank you for reviewing. I realized at made time needed there. I will revert as previous one as I do not want to make any unnecessary changes when the previous one is already right. Thank you! 😃
calda
approved these changes
Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed few typos to increase readability and clarity of the document.
Reasoning
typealiasesis listed astype aliasesin the official document. And, I fixed few words (timedoesn't contain any meaning aswhenevermeans occasion already, and I strongly believestatic vars is typo.Please react with 👍/👎 if you agree or disagree with this proposal.