Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document that authenticated users can send email as others #62

Open
albertito opened this issue Jan 28, 2025 · 1 comment
Open

Document that authenticated users can send email as others #62

albertito opened this issue Jan 28, 2025 · 1 comment
Assignees

Comments

@albertito
Copy link
Owner

albertito commented Jan 28, 2025

Authenticated users are intentionally allowed to send email as other users or domains.

This is a design choice made to balance simplicity of operation and use. However, it can be surprising, and it should be documented much more clearly.

Users who want to be strict about "MAIL FROM" or even "From:" validation can add additional checks in the post-DATA hook.

In the future, chasquid may get some option to be strict about it by default, or on a per-domain or per-user basis. But for now, using a post-DATA hook is the best way to make chasquid more strict about this. I'll try to include some examples for this in the documentation too.

Thanks to Matěj Volf for reporting this issue!

@albertito albertito self-assigned this Jan 28, 2025
albertito added a commit that referenced this issue Feb 1, 2025
Authenticated users are intentionally allowed to send email as other users or
domains. This is a design choice made to balance simplicity of operation and
use.

However, it can be surprising and it's not obvious, so this patch adds a
note to the documentation about it.

Thanks to Matěj Volf for suggesting this improvement!

Fixes: #62
@mvolfik
Copy link

mvolfik commented Feb 27, 2025

btw, here's a patch that I deployed to my own server that implements this check in chasquid itself. It's patched in the obvious place with least possible effort while staying compatible with old users config file, not sure if there's any interest in merging this, but I just wanted to offer it: main...mvolfik:chasquid:main

(there's also a patch of the sender address of delivery status notifications - I'm forwarding my received emails to gmail, and it refused to accept the <> from address)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants