Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doubled the height of the TextInput on iPad #100

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Conversation

jonryser
Copy link
Collaborator

@jonryser jonryser commented Dec 3, 2024

Describe the changes

Doubled the height of the TextField when on iPad.

iPad with no input:
Simulator Screenshot - iPad Pro 13-inch (M4) - 2024-12-03 at 14 46 13

iPad with a single line of text:
Simulator Screenshot - iPad Pro 13-inch (M4) - 2024-12-03 at 14 47 29

iPad with multiple lines of text:
Simulator Screenshot - iPad Pro 13-inch (M4) - 2024-12-03 at 14 48 23

iPhone with no input:
Simulator Screenshot - iPhone 16 - 2024-12-03 at 14 44 11

iPhone with a single line of text:
Simulator Screenshot - iPhone 16 - 2024-12-03 at 14 44 30

iPhone with multiple lines of text:
Simulator Screenshot - iPhone 16 - 2024-12-03 at 14 45 43

Issue ticket number and link

#78

Checklist before requesting a review

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my code.
  • I have tested my changes and ensured that they work as expected.
  • I have updated examples and documentation as necessary.
  • I have incremented the version number in the appropriate files.

@jonryser jonryser requested review from Stanley-Jovel and ThomasJones and removed request for Stanley-Jovel December 3, 2024 23:03
Copy link
Collaborator

@Stanley-Jovel Stanley-Jovel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jonryser jonryser merged commit 59c2ec7 into release-20241118 Dec 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants