Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Gemini and Claude runners with a viewer. #62

Merged
merged 13 commits into from
Feb 28, 2025
Merged

Added Gemini and Claude runners with a viewer. #62

merged 13 commits into from
Feb 28, 2025

Conversation

aman-17
Copy link
Member

@aman-17 aman-17 commented Feb 28, 2025

Added run_gemini, run_claude, viewer for comparing outputs from both the models.

Copy link
Collaborator

@jakep-allenai jakep-allenai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments.

@@ -1,2 +1 @@
class DolmaRefineError(RuntimeError):
...
class DolmaRefineError(RuntimeError): ...
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't include this file plz.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was already there, I just formatted it using isort

- Fixed git checks
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to edit this file, it's processed automatically.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think updating changelog manually helps us a lot in the long run if we want to check any PR.

@aman-17
Copy link
Member Author

aman-17 commented Feb 28, 2025

Left a few comments.

Thanks Jake for reviewing the PR, followed your instructions and made changes :)

@aman-17 aman-17 merged commit 37b32d7 into main Feb 28, 2025
5 of 7 checks passed
@aman-17 aman-17 deleted the amanr/bench branch February 28, 2025 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants