Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@angular/build): ensure index.csr.html is always generated when prerendering or SSR are enabled #28594

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

alan-agius4
Copy link
Collaborator

This commit addresses an issue where index.csr.html was not being generated when SSR was disabled and prerendering was enabled.

Closes #28580

@alan-agius4 alan-agius4 requested a review from clydin October 8, 2024 07:37
@alan-agius4 alan-agius4 added the action: review The PR is still awaiting reviews from at least one requested reviewer label Oct 8, 2024
@alan-agius4 alan-agius4 added the target: minor This PR is targeted for the next minor release label Oct 8, 2024
… prerendering or SSR are enabled

This commit addresses an issue where `index.csr.html` was not being generated when SSR was disabled and prerendering was enabled.

Closes angular#28580
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 9, 2024
@alan-agius4 alan-agius4 merged commit 7c50ba9 into angular:main Oct 9, 2024
31 checks passed
@alan-agius4 alan-agius4 deleted the index-ssr-prerender branch October 9, 2024 08:29
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: @angular/build target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prerendered home page overwrites app-shell, causing flash of home page on non-prerendered routes
2 participants