Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@schematics/angular): skip ssr migration when @angular/ssr is not a dependency #29564

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

alan-agius4
Copy link
Collaborator

This commit updates the update-ssr-imports migration to not run when the @angular/ssr` package is not listed as a dependency.

Closes #29560

…ot a dependency

This commit updates the `update-ssr-imports` migration to not run when the @angular/ssr` package is not listed as a dependency.

Closes angular#29560
@alan-agius4 alan-agius4 requested a review from jkrems February 3, 2025 22:33
@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release and removed area: @schematics/angular labels Feb 3, 2025
@jkrems jkrems added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Feb 3, 2025
@alan-agius4 alan-agius4 merged commit c716ce1 into angular:main Feb 3, 2025
34 checks passed
@alan-agius4 alan-agius4 deleted the ssr-migration branch February 3, 2025 23:13
@alan-agius4
Copy link
Collaborator Author

The changes were merged into the following branches: main, 19.1.x

@oritpersik
Copy link

When can i use it ? i see its only on branches and not on closed tag ..

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ng update @angular/core@19 @angular/cli@19 Failed.
3 participants