fix(@angular/cli): prefix historyApiFallback.index with deployUrl
#6279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@smoke Please fix the commit message https://github.com/angular/angular-cli/blob/master/CONTRIBUTING.md#commit |
smoke
force-pushed
the
ng-serve-set-proper-historyApiFallback-index-when-deployUrl-given
branch
3 times, most recently
from
0efc7e8 to
39a191a
Compare
smoke
changed the title
historyApiFallback.index with deployUrlhistoryApiFallback.index with deployUrl
when implementing i18n following https://angular.io/docs/ts/latest/cookbook/i18n.html and https://medium.com/@feloy/deploying-an-i18n-angular-app-with-angular-cli-fc788f17e358 when running in `development` to be consistent with `production` I am using ``` ng serve --deploy-url /en/ --base-href /en/ \ --aot --locale en --i18n-file ./src/locale/messages.en.xlf ``` running the app this way, on routes other than `http://localhost:4200/en/` the `webpack-dev-server` was always saying that the route is not found, so this commit fixes that
smoke
force-pushed
the
ng-serve-set-proper-historyApiFallback-index-when-deployUrl-given
branch
from
39a191a to
8de8bc6
Compare
|
@sumitarora Everything should be good now. |
filipesilva
approved these changes
May 12, 2017
smoke
deleted the
ng-serve-set-proper-historyApiFallback-index-when-deployUrl-given
branch
smoke
restored the
ng-serve-set-proper-historyApiFallback-index-when-deployUrl-given
branch
|
@smoke this wasn't merged yet, it was just marked for a merge. Can you reopen the PR so we can merge it? |
|
Reopening the PR as I accidentally closed it, sorry. |
2 tasks
smoke
deleted the
ng-serve-set-proper-historyApiFallback-index-when-deployUrl-given
branch
sumitarora
pushed a commit
that referenced
this pull request
May 15, 2017
…#6279) when implementing i18n following https://angular.io/docs/ts/latest/cookbook/i18n.html and https://medium.com/@feloy/deploying-an-i18n-angular-app-with-angular-cli-fc788f17e358 when running in `development` to be consistent with `production` I am using ``` ng serve --deploy-url /en/ --base-href /en/ \ --aot --locale en --i18n-file ./src/locale/messages.en.xlf ``` running the app this way, on routes other than `http://localhost:4200/en/` the `webpack-dev-server` was always saying that the route is not found, so this commit fixes that
sumitarora
pushed a commit
that referenced
this pull request
May 18, 2017
dond2clouds
pushed a commit
to d2clouds/speedray-cli
that referenced
this pull request
Apr 23, 2018
…angular#6279) when implementing i18n following https://angular.io/docs/ts/latest/cookbook/i18n.html and https://medium.com/@feloy/deploying-an-i18n-angular-app-with-angular-cli-fc788f17e358 when running in `development` to be consistent with `production` I am using ``` ng serve --deploy-url /en/ --base-href /en/ \ --aot --locale en --i18n-file ./src/locale/messages.en.xlf ``` running the app this way, on routes other than `http://localhost:4200/en/` the `webpack-dev-server` was always saying that the route is not found, so this commit fixes that
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when implementing i18n following https://angular.io/docs/ts/latest/cookbook/i18n.html
and https://medium.com/@feloy/deploying-an-i18n-angular-app-with-angular-cli-fc788f17e358
when running in
developmentto be consistent withproductionI am usingrunning the app this way, on routes other than
http://localhost:4200/en/the
webpack-dev-serverwas always saying that the route is not found,so this commit fixes that