Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCSS 'WebP' image load #6532

Closed
wants to merge 1 commit into from
Closed

Conversation

Gusachenko
Copy link
Contributor

issue : #6526

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@filipesilva filipesilva self-assigned this Jun 1, 2017
@filipesilva
Copy link
Contributor

LGTM 👍

@filipesilva
Copy link
Contributor

Heya, can you have a look at the CLA? We cannot merge without it.

@Gusachenko
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Jun 1, 2017
@Gusachenko
Copy link
Contributor Author

Gusachenko commented Jun 1, 2017

@filipesilva i'm reviewed CLAs, thanks!

Copy link
Contributor

@filipesilva filipesilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit messages are used to generated the changelog in Angular CLI, and it seems like yours doesn't fit the necessary format (which signals a failure in the CI).

Could you change it to feat(@angular/cli): support loading webp images please?

@Gusachenko Gusachenko changed the title SCSS 'WebP' image load feat(@angular/cli): support loading webp images Jun 6, 2017
@Gusachenko
Copy link
Contributor Author

new PR, with corresponding commit message: #6594

@Gusachenko Gusachenko changed the title feat(@angular/cli): support loading webp images SCSS 'WebP' image load Jun 6, 2017
@filipesilva
Copy link
Contributor

Closing in favor of #6594

@filipesilva filipesilva closed this Jun 7, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants