fix(cdk/overlay): flexible overlay screen overflow #29904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Segdo
requested review from
crisbeto and
andrewseguin
and removed request for
a team
Add max-height to flexible positioned overlays to prevent them from overflowing out of the scrollable window. Fixes angular#13829 Fixes angular#18901
Segdo
force-pushed
the
fix-overlay-overflow
branch
from
5166136 to
2e7ecd1
Compare
|
Also want to add that this is an accessibility issue because users with high zoom can't reach all select options. Like in this image on 300% zoom, the user can't see the 4th option "Cheddar": |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should prevent selects and some other overlays from going out of screen on the y-axis so users can't reach them fully.
Fixes #13829
Fixes #18901