This repository was archived by the owner on Apr 9, 2022. It is now read-only.
App root schematics #149
Merged
App root schematics #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and fix the lint errors.
hansl
added a commit
to hansl/angular-cli
that referenced
this pull request
Sep 14, 2017
This depends on angular/devkit#149 Fixes angular#7695
filipesilva
suggested changes
Sep 14, 2017
| @@ -11,6 +11,10 @@ | |||
| "type": "string", | |||
| "default": "app" | |||
| }, | |||
| "appRoot": { | |||
| "type": "string", | |||
| "default": "app" | |||
There was a problem hiding this comment.
We shouldn't have a default to ensure backwards compatibility with CLI versions that aren't sending the appRoot options.
When creating schematics with names that are paths, the path option is the path to create the schematic into. we need to app root to discover the module.
hansl
force-pushed
the
app-root-schematics
branch
from
20aeee5 to
e0ea4ff
Compare
filipesilva
approved these changes
Sep 14, 2017
Brocco
pushed a commit
to angular/angular-cli
that referenced
this pull request
Sep 20, 2017
This depends on angular/devkit#149 Fixes #7695
Brocco
pushed a commit
to angular/angular-cli
that referenced
this pull request
Sep 22, 2017
This depends on angular/devkit#149 Fixes #7695
Brocco
pushed a commit
to angular/angular-cli
that referenced
this pull request
Sep 22, 2017
This depends on angular/devkit#149 Fixes #7695
dond2clouds
pushed a commit
to d2clouds/speedray-cli
that referenced
this pull request
Apr 23, 2018
This depends on angular/devkit#149 Fixes angular#7695
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.