Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for interface Tunnel #145

Merged
merged 3 commits into from
Oct 1, 2020
Merged

Added support for interface Tunnel #145

merged 3 commits into from
Oct 1, 2020

Conversation

benjdudas
Copy link
Contributor

SUMMARY

Fixes: #144

ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
  • Feature Pull Request
  • New Module Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

@justjais
Copy link
Member

@benjdudas Thanks for raising the PR for fixing the issue, changes LGTM can you please add changelog for the PR for the tests to pass.

@benjdudas
Copy link
Contributor Author

@justjais changelog added

@justjais
Copy link
Member

recheck

@justjais justjais added the mergeit Gate PR in Zuul CI label Sep 25, 2020
@justjais
Copy link
Member

@benjdudas can u rebase the fix and update the PR as that's stopping the PR from getting merged.

@ansible-zuul ansible-zuul bot removed the mergeit Gate PR in Zuul CI label Sep 25, 2020
@benjdudas
Copy link
Contributor Author

@justjais rebased

@justjais justjais added mergeit Gate PR in Zuul CI and removed mergeit Gate PR in Zuul CI labels Sep 26, 2020
@ansible-zuul ansible-zuul bot merged commit 5881be9 into ansible-collections:main Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justjais justjais justjais approved these changes

Assignees
No one assigned
Labels
mergeit Gate PR in Zuul CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IOS Tunnel interfaces are being ignored with ios_l3_interfaces module
2 participants
@benjdudas @justjais