Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement]: Support list partitions via flink catalog #1940

Closed
2 of 3 tasks
Tracked by #1847
YesOrNo828 opened this issue Sep 8, 2023 · 2 comments · Fixed by #1994
Closed
2 of 3 tasks
Tracked by #1847

[Improvement]: Support list partitions via flink catalog #1940

YesOrNo828 opened this issue Sep 8, 2023 · 2 comments · Fixed by #1994
Assignees
Labels
module:mixed-flink Flink moduel for Mixed Format type:improvement

Comments

@YesOrNo828
Copy link
Contributor

Search before asking

  • I have searched in the issues and found no similar issues.

What would you like to be improved?

Now the flink catalog is not implemented public List<CatalogPartitionSpec> listPartitions(ObjectPath tablePath) interface; so SHOW PARTITIONS statement is not supported.

How should we improve?

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Subtasks

No response

Code of Conduct

@YesOrNo828 YesOrNo828 added type:improvement module:mixed-flink Flink moduel for Mixed Format labels Sep 8, 2023
@huyuanfeng2018
Copy link
Contributor

I can complete this part of the work, but from my practice, listing all partitions will definitely scan all metadata. For some large tables, this may take a long time, which will put a certain amount of pressure on the flinkclient that runs the statement.

@YesOrNo828
Copy link
Contributor Author

I can complete this part of the work, but from my practice, listing all partitions will definitely scan all metadata. For some large tables, this may take a long time, which will put a certain amount of pressure on the flinkclient that runs the statement.

@huyuanfeng2018 Thanks for volunteering to fix it. I've assigned it to you. I think your consideration is reasonable, and we also need to scan two tables including the change and base table, if the mixed-format table is a Keyed Table.

czy006 added a commit to czy006/amoro that referenced this issue Oct 11, 2023
zhoujinsong added a commit that referenced this issue Oct 11, 2023
* [AMORO-1983][Feature] Copy From Flink 1.15 Code to Flink 1.17

* [AMORO-1983][Feature] Flink 1.17 API compatible

* [AMORO-1983][Feature] Copy From Flink 1.15 Test Code to Flink 1.17 Test Code

* [AMORO-1983][fix] fix package rename to planner

* [AMORO-1983][Feature] Flink 1.17 Mode Test Fix

* [AMORO-1983][Feature] fix pom

* [AMORO-1983] FlinkSplitPlanner Remove SequenceNumber

* [AMORO-1983] TestUnkeyed Replace to KafkaContainer Test

* Add KafkaContainerTest CountAllRecords

* Remove KafkaTestBase

* spotless code

* fix TestCatalog use default after drop catalog

* fix LookupITCase set streaming true

* fix checkstyle

* fix test timeout thread commit failed

* remove bridge to public common

* fix pom problem

* patch #1940

---------

Co-authored-by: ZhouJinsong <[email protected]>
@shidayang shidayang mentioned this issue Oct 17, 2023
70 tasks
ShawHee pushed a commit to ShawHee/arctic that referenced this issue Dec 29, 2023
…#2001)

* [AMORO-1983][Feature] Copy From Flink 1.15 Code to Flink 1.17

* [AMORO-1983][Feature] Flink 1.17 API compatible

* [AMORO-1983][Feature] Copy From Flink 1.15 Test Code to Flink 1.17 Test Code

* [AMORO-1983][fix] fix package rename to planner

* [AMORO-1983][Feature] Flink 1.17 Mode Test Fix

* [AMORO-1983][Feature] fix pom

* [AMORO-1983] FlinkSplitPlanner Remove SequenceNumber

* [AMORO-1983] TestUnkeyed Replace to KafkaContainer Test

* Add KafkaContainerTest CountAllRecords

* Remove KafkaTestBase

* spotless code

* fix TestCatalog use default after drop catalog

* fix LookupITCase set streaming true

* fix checkstyle

* fix test timeout thread commit failed

* remove bridge to public common

* fix pom problem

* patch apache#1940

---------

Co-authored-by: ZhouJinsong <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:mixed-flink Flink moduel for Mixed Format type:improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants