[Improvement] Polish optimizing executor code #1895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
module:core
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1895 +/- ##
============================================
- Coverage 50.79% 50.77% -0.02%
+ Complexity 3786 3784 -2
============================================
Files 477 477
Lines 25568 25560 -8
Branches 2610 2606 -4
============================================
- Hits 12986 12978 -8
+ Misses 11417 11416 -1
- Partials 1165 1166 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
zhoujinsong
reviewed
Aug 29, 2023
core/src/main/java/com/netease/arctic/optimizing/OptimizingExecutor.java
Show resolved
Hide resolved
zhoujinsong
reviewed
Aug 29, 2023
core/src/main/java/com/netease/arctic/optimizing/OptimizingDataReader.java
Show resolved
Hide resolved
wangtaohz
approved these changes
Aug 29, 2023
ShawHee
pushed a commit
to ShawHee/arctic
that referenced
this pull request
Dec 29, 2023
* Polish code * Polish code * Code format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
There are some flaws in the code.
Brief change log
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation