[AMORO-2032]: Spark3.2 version does not require the class ResolveProcedures #2035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅ see 3 files with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
|
Can you provide a screenshot of using the packaged runtime.jar in the Spark engine? It's because unit tests for the Spark module don't test whether shade is reasonable or not. |
|
Thanks for your contribution! 👍 @bdxmq It looks like a miss for Spark 3.2. If you verify it successfully in your enviromnent, we can merge it and consider including it in version 0.5.1. |
|
I removed this line of code locally, packaged it, and used Spark SQL to use queries normally |
baiyangtx
changed the title
baiyangtx
approved these changes
Sep 26, 2023
wangtaohz
pushed a commit
that referenced
this pull request
Sep 26, 2023
…edures (#2035) fix:Spark3.2 version does not require the class ResolveProcedures
ShawHee
pushed a commit
to ShawHee/arctic
that referenced
this pull request
Dec 29, 2023
…edures (apache#2035) fix:Spark3.2 version does not require the class ResolveProcedures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
When using amoro spark-3.2-runtime-0.5.0.jar, an error was reported and the class ResolveProcedures could not be found. Through comparison, it was found that changing the class is no longer necessary. Simply remove the dependency of this class.
Close #2032 .
Brief change log
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation