[AMORO-2009]: Add aws/s3/hadoop-aws and iceberg-aws as default dependenies. #2080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
module:core
Codecov ReportAll modified lines are covered by tests ✅ see 3 files with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
zhoujinsong
reviewed
Oct 11, 2023
zhoujinsong
reviewed
Oct 11, 2023
XBaith
reviewed
Oct 11, 2023
| <dependency> | ||
| <groupId>org.apache.hadoop</groupId> | ||
| <artifactId>hadoop-aws</artifactId> | ||
| </dependency> |
There was a problem hiding this comment.
What are the scenarios where we need to use hadoop-aws dependency
There was a problem hiding this comment.
to support s3a:// file system with hive
| </dependency> | ||
| </dependencies> | ||
| </profile> | ||
| </profiles> |
There was a problem hiding this comment.
One thing I'm not so sure about is: amoro-core is used in multiple modules, will moving to the aws-server module affect the service?
There was a problem hiding this comment.
aws sdk shoud be controlled by compute engines. Amoro connectors should not shade them.
|
Works in locally and minio standalone cluster.
|
wangtaohz
reviewed
Oct 12, 2023
ShawHee
pushed a commit
to ShawHee/arctic
that referenced
this pull request
Dec 29, 2023
…enies. (apache#2080) * hadoop-aws pom * enable aws profile * add aws sdk and s3 dependencies . * include iceberg-aws for runtime * iceberg-aws scope to compile * fix spark run --------- Co-authored-by: ZhouJinsong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Close #2009.
Brief change log
iceberg-awsas default dependenies for all modulehadoop-aws,awssdkto AMS module depndenies.How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation