[Fix] Fix the format of thread name in DefaultTableService #2163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
... and 2 files with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
zhoujinsong
reviewed
Oct 23, 2023
| @@ -58,7 +58,7 @@ public class DefaultTableService extends StatedPersistentBase implements TableSe | |||
|
|
|||
| private final ScheduledExecutorService tableExplorerScheduler = Executors.newSingleThreadScheduledExecutor( | |||
| new ThreadFactoryBuilder() | |||
| .setNameFormat("table-explorer-scheduler") | |||
| .setNameFormat("table-explorer-scheduler-%d") | |||
There was a problem hiding this comment.
It seems to be fine as this is a single-thread pool.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the format of thread name in DefaultTableService