[Improvement]: Using unified catalog for server external catalog. #2232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
module:core
Codecov ReportAttention:
... and 9 files with indirect coverage changes 📢 Thoughts on this report? Let us know! |
baiyangtx
requested review from
majin1102,
zhoujinsong,
shidayang and
wangtaohz
shidayang
reviewed
Nov 6, 2023
| import java.util.Set; | ||
|
|
||
| public class CatalogBuilder { | ||
|
|
||
| // TODO: use internal or external concepts | ||
| /** matrix of catalog type and supported table formats */ | ||
| private static final Map<String, Set<TableFormat>> formatSupportedMatrix = |
There was a problem hiding this comment.
What formats are supported by each catalog is quite important information. For example, CatalogController has similar information. Can you expose and share this information?
There was a problem hiding this comment.
I also think these two parts are somewhat repetitive.
BTW, for the variable name of "static final", it is better to use capital letters with underscores.
ams/server/src/main/java/com/netease/arctic/server/catalog/ExternalCatalog.java
Outdated
Show resolved
Hide resolved
|
BTW, Your need test in local kerberos env |
wangtaohz
reviewed
Nov 6, 2023
|
Need add UT for AmoroCatalog of mixed-format |
wangtaohz
reviewed
Nov 6, 2023
zhoujinsong
reviewed
Nov 7, 2023
core/src/main/java/com/netease/arctic/catalog/BasicIcebergCatalog.java
Outdated
Show resolved
Hide resolved
zhoujinsong
reviewed
Nov 8, 2023
core/src/test/java/com/netease/arctic/catalog/TableTestBase.java
Outdated
Show resolved
Hide resolved
ams/server/src/test/java/com/netease/arctic/server/AmsEnvironment.java
Outdated
Show resolved
Hide resolved
# Conflicts: # core/src/main/java/com/netease/arctic/utils/ArcticTableUtil.java
wangtaohz
approved these changes
Nov 8, 2023
3 tasks
ShawHee
pushed a commit
to ShawHee/arctic
that referenced
this pull request
Dec 29, 2023
…ache#2232) * Using unified catalog for server external catalog. * fix hard code texts. * spotless:apply * add deprecated of ArcticCatalog initialize * remove useless initialize * remove useless code. * remove catalog.refresh() * spotless:apply * fix unit tests. * catalog impl to private * build catalog to private * remove IcebergCatalogWrapper.java * spotless:apply * remove useless comments. * remove useless code. * spotless:apply * fix unit tests in core * fix unit tests. * apply spotless
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
This is a subtask of #1061.
In this PR, the AMS will use UnifiedCatalog as ExternalCatalog implement.
Brief change log
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation