Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMORO-2326] Fixed the bug that some catalog configurations did not take effect #2327

Closed
wants to merge 1 commit into from

Conversation

huyuanfeng2018
Copy link
Contributor

Why are the changes needed?

Close #2326.

Brief change log

  • Initialize database.filter-regular-expression and table-filter configuration in CommonUnifiedCatalog

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@github-actions github-actions bot added the module:core Core module label Nov 20, 2023
Copy link

codecov bot commented Nov 20, 2023

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (d48c0e0) 52.94% compared to head (3236eb0) 52.57%.

Files Patch % Lines
.../java/com/netease/arctic/CommonUnifiedCatalog.java 31.81% 12 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2327      +/-   ##
============================================
- Coverage     52.94%   52.57%   -0.38%     
- Complexity     3612     4201     +589     
============================================
  Files           465      511      +46     
  Lines         24502    29284    +4782     
  Branches       2340     2864     +524     
============================================
+ Hits          12973    15396    +2423     
- Misses        10510    12645    +2135     
- Partials       1019     1243     +224     
Flag Coverage Δ
core 52.95% <31.81%> (+<0.01%) ⬆️
trino 50.64% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wangtaohz
Copy link
Contributor

Thanks for you contribution, but there has been a PR to fix it #2310.

@huyuanfeng2018
Copy link
Contributor Author

Thanks for you contribution, but there has been a PR to fix it #2310.

That's great, I'll close this PR and issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:core Core module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Some catalog properties do not take effect
2 participants